Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the binaries with static linking and without CGO. #34

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Build the binaries with static linking and without CGO. #34

merged 2 commits into from
Jun 25, 2020

Conversation

evanmcclure
Copy link
Member

Changes:

  • Build the binaries without CGO.
  • Use static linking.
  • Use the scratch base image in the runtime container.
  • Replace the docker entrypoint shell script with a Go binary, because there isn't a shell.
  • Reduce the complexity of the Dockerfile.

Closes #33

Changes:
- Build the binaries without CGO.
- Use static linking.
- Use the scratch base image in the runtime container.
- Replace the docker entrypoint shell script with a Go binary, because there isn't a shell.
- Reduce the complexity of the Dockerfile.

Closes #33
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #34 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   60.81%   60.81%           
=======================================
  Files         112      112           
  Lines        5897     5897           
=======================================
  Hits         3586     3586           
  Misses       2111     2111           
  Partials      200      200           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0f889...b135002. Read the comment docs.

@matteo-grella matteo-grella merged commit 0eddb8a into nlpodyssey:main Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use static linking when building Go binaries for Docker image
2 participants