Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix find_concordance() returning empty list for left_context #2103

Merged
merged 1 commit into from Sep 18, 2018
Merged

Fix find_concordance() returning empty list for left_context #2103

merged 1 commit into from Sep 18, 2018

Conversation

dnc1994
Copy link
Contributor

@dnc1994 dnc1994 commented Sep 1, 2018

Patching #2088

@alvations alvations self-requested a review September 1, 2018 08:56
@alvations
Copy link
Contributor

Thanks @dnc1994 for the contribution! LGTM =)

BTW, since [CI: retest] hasn't worked on Travis. I've manually created a branch checkout to run the test on https://travis-ci.org/nltk/nltk/builds/429420483

alvations
alvations approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@alvations alvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevenbird
Copy link
Member

Thanks @dnc1994

@stevenbird stevenbird merged commit b991f24 into nltk:develop Sep 18, 2018
@alvations alvations mentioned this pull request Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvations alvations alvations approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnc1994 @alvations @stevenbird