Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI matrix #2211

Merged
merged 3 commits into from Jan 24, 2019
Merged

Update Travis CI matrix #2211

merged 3 commits into from Jan 24, 2019

Conversation

kevin-brown
Copy link
Contributor

@kevin-brown kevin-brown commented Jan 6, 2019

  • Remove sudo from Python 3.7 builds
  • Test on Python 3.4

Now that Xenial builds for Python 3.7 are official, sudo is no longer required.
This is officially supported by the setup.py and the documentation, so let's see if tests will run on it.
@kevin-brown kevin-brown changed the title [WIP] Update Travis CI matrix Update Travis CI matrix Jan 6, 2019
@alvations
Copy link
Contributor

@kevin-brown Thanks for the contribution!

I think py3.4 was purposely dropped to minimize tests and also encourage people to move on to newer Python3 versions. Could you revise your commits and remove the Py3.4 tests?

@kevin-brown
Copy link
Contributor Author

I added Python 3.4 to the testing matrix because it looks like NLTK officially supports Python 3.4. While I'm in favor of removing it if it's no longer supported, we should probably also remove it from the other places where it is referenced:

Otherwise I'm hesitant to recommend that we don't test on Python 3.4 when it's a version of Python that NLTK claims to officially support.

@alvations
Copy link
Contributor

@stevenbird could we drop support for Python 3.4? If so, @kevin-brown do you mind removing that from the setup.py and install.rst?

stevenbird added a commit that referenced this pull request Jan 12, 2019
@stevenbird
Copy link
Member

@kevin-brown: ready for you to drop the change concerning Python 3.4 from your PR

@kevin-brown
Copy link
Contributor Author

Sorry for the delay. I dropped Python 3.4 so now it's just the changes to the Python 3.7 builds.

@alvations alvations self-requested a review January 21, 2019 00:51
Copy link
Contributor

@alvations alvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing sudo from Travis =)

@stevenbird stevenbird merged commit 06a5bd9 into nltk:develop Jan 24, 2019
@stevenbird
Copy link
Member

Thanks @kevin-brown, @alvations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants