New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Travis CI matrix #2211
Update Travis CI matrix #2211
Conversation
kevin-brown
commented
Jan 6, 2019
•
edited
edited
- Remove sudo from Python 3.7 builds
- Test on Python 3.4
Now that Xenial builds for Python 3.7 are official, sudo is no longer required.
This is officially supported by the setup.py and the documentation, so let's see if tests will run on it.
@kevin-brown Thanks for the contribution! I think py3.4 was purposely dropped to minimize tests and also encourage people to move on to newer Python3 versions. Could you revise your commits and remove the Py3.4 tests? |
I added Python 3.4 to the testing matrix because it looks like NLTK officially supports Python 3.4. While I'm in favor of removing it if it's no longer supported, we should probably also remove it from the other places where it is referenced:
Otherwise I'm hesitant to recommend that we don't test on Python 3.4 when it's a version of Python that NLTK claims to officially support. |
@stevenbird could we drop support for Python 3.4? If so, @kevin-brown do you mind removing that from the |
@kevin-brown: ready for you to drop the change concerning Python 3.4 from your PR |
Sorry for the delay. I dropped Python 3.4 so now it's just the changes to the Python 3.7 builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing sudo from Travis =)
Thanks @kevin-brown, @alvations |