Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made nltk/__init__.py equivalent to setup.py #2787

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

tomaarsen
Copy link
Member

Fixes #2509

Hello!

Pull request overview

  • Made nltk/__init__.py equivalent to setup.py in terms of project description, classifiers, etc.

Changes

I simply updated all dunder variables in nltk/__init__.py to be equivalent to their corresponding variables in setup.py. This includes changes to:

  • Long description.
  • Maintainer.
  • Trove classifiers.

Note

I simply copied the values from setup.py, but as a consequence two names are removed from the maintainer list here!

  • Tom Aarsen

@stevenbird stevenbird merged commit 193cf48 into nltk:develop Aug 18, 2021
@stevenbird
Copy link
Member

Thanks @tomaarsen, good catch!

@iliakur
Copy link
Contributor

iliakur commented Aug 19, 2021

Would it be possible to reuse this string in setup.py directly? I dunno if that'll work, but seems like a good way to reduce duplication. Just to minimize the number of things we have to keep consistent...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove outdated names in init.py
3 participants