Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(childes): use correct xmlns #2998

Merged
merged 1 commit into from May 9, 2022
Merged

fix(childes): use correct xmlns #2998

merged 1 commit into from May 9, 2022

Conversation

sid-maddy
Copy link
Contributor

Fixes #2997

@sid-maddy
Copy link
Contributor Author

@stevenbird, sorry for the mention, but could you take a look at this PR?

@tomaarsen tomaarsen merged commit de46911 into nltk:develop May 9, 2022
@tomaarsen
Copy link
Member

I was able to reproduce the issue, and this PR does seem to resolve the issue. It's clear what caused this issue - the recent update from https to http on many links. I must've been too careless here, as the xml obviously still requires http in this case. Thank you for bringing this to our attention and providing this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CHILDES Corpus Reader doesn't parse data correctly
2 participants
@sid-maddy @tomaarsen