_PY3_DATA_UPDATES uses win path if on win #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
py3_data function does not work on windows as the item would never match a value in a windows path. _PY3_DATA_UPDATES now has a windows version if windows is used This is only a quick fix as having the list of theses data directories is not perfect.
|
Thanks for this. While it's not the final solution it's a helpful step in that direction. |
stevenbird
added a commit
that referenced
this pull request
Oct 26, 2014
_PY3_DATA_UPDATES uses win path if on win
| _PY3_DATA_UPDATES = ["chunkers/maxent_ne_chunker", | ||
| "help/tagsets", | ||
| "taggers/maxent_treebank_pos_tagger", | ||
| "tokenizers/punkt"] |
There was a problem hiding this comment.
os.path.join() should join fragments correctly, taking care of '/' and ''.
There was a problem hiding this comment.
Yes, that would be much cleaner, if you don't mind submitting a patch!
|
could you reopen the issue and assign it to me, so it doesn't get lost. |
Closed
|
cool! thanks |
inteldict
pushed a commit
to inteldict/nltk
that referenced
this pull request
Jul 15, 2015
_PY3_DATA_UPDATES uses win path if on win
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py3_data function does not work on windows as the item would never match a value in a windows path.
_PY3_DATA_UPDATES now has a windows version if windows is used
This is only a quick fix as having the list of theses data directories is not perfect.