[WIP] determine folding points on each wire and connect them #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determine the folding points of each wire by considering straight lines start/end points, and chunks of edges that aren't straight lines. Then, try to connect these points. The technique used here (which produces inedequate output) consists in projecting the points of a face on the other face and match the closest points. C.f. https://forum.freecad.org/viewtopic.php?p=666788#p666788
Try to implement buildFoldingLinesOnCurvedEdges from buildFoldingLinesOnStraightEdges, but it doesn't lead to any satisfying output. Just committing it in order to continue research. See https://forum.freecad.org/viewtopic.php?p=667765#p667765
fixes commit 7243258 . Blindly inverting the tangent direction of straight lines ends was working for some cases but not for others. Using the continuous sorted edges array is a better solution.
…t is used by multiple folding lines
Create cosmetic folding lines in the middle of straight edges. There is no folding on such CosmeticFoldingLine, it is only used as a guide. It would also be nice to draw them in a different color, but it seems that changing a line color requires a `Part::Feature` object added to the active document :/ cf https://forum.freecad.org/viewtopic.php?t=7335
flatten representation
i.e. not only straight edges
nm2107
force-pushed
the
feat/sketches-selection-and-non-linear-edges-division
branch
from
9bd1298
to
d360c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determine the folding points of each wire by considering straight lines start/end points, and chunks of edges that aren't straight lines.
Then, try to connect these points. The technique used here (which produces inedequate output) consists in projecting the points of a face on the other face and match the closest points.
C.f. https://forum.freecad.org/viewtopic.php?p=666788#p666788