Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase stack reservation size of NPFInstall.exe #1951

Open
dmiller-nmap opened this issue Mar 5, 2020 · 2 comments
Open

Increase stack reservation size of NPFInstall.exe #1951

dmiller-nmap opened this issue Mar 5, 2020 · 2 comments

Comments

@dmiller-nmap
Copy link

@dmiller-nmap dmiller-nmap commented Mar 5, 2020

According to @akontsevoy in #1910, NPFInstall.exe should increase its stack reservation size. We should investigate this and make any necessary changes.

@akontsevoy

This comment has been minimized.

Copy link

@akontsevoy akontsevoy commented Mar 5, 2020

https://docs.microsoft.com/en-us/cpp/build/reference/stack-stack-allocations?view=vs-2019
I meant this specific option. Only the reserve size (the amount of address space to reserve for the stack) should be increased, not the commit size, so this should not affect the actual memory requirements of the program (barring the cases of infinite recursion, where any reasonable allocation results in a speedy crash anyway).

@dmiller-nmap

This comment has been minimized.

Copy link
Author

@dmiller-nmap dmiller-nmap commented Mar 12, 2020

nmap/npcap@8226406 will improve stack usage somewhat in the case of recording WiFi adapters in the registry, by allocating space for an array of WLAN_INTERFACE_INFO structures on the heap and passing pointers to it as function parameters. Previously, an array of size 64 was allocated on the stack, which was then passed by value to another function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.