fixed a bug for str case conversion before str compare#1209
Closed
jeswinMathai wants to merge 1 commit intonmap:masterfrom
jeswinMathai:master
Closed
fixed a bug for str case conversion before str compare#1209jeswinMathai wants to merge 1 commit intonmap:masterfrom jeswinMathai:master
jeswinMathai wants to merge 1 commit intonmap:masterfrom
jeswinMathai:master
Conversation
without conversion, the small case "md5" string fails to match and result variable remains uninitialized, "attempt to index a nil value" error is thrown on line 812. At all rest of the places the string is converted to uppercase before comparision except on line 807
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without conversion, the small case "md5" string fails to match, condition fails and the result variable remains uninitialized, due to which "attempt to index a nil value" error is thrown on line 812. the authorization string is converted to uppercase before comparison everywhere except on line 807