Service Detection: Add Ubiquiti Discovery Service on 10001/udp

[TomSellers]

This PR adds UDP service probe and match lines for Ubiquiti Discovery Service on 10001/udp.

NOTE : The PR has been updated to include coverage of v2 of the protocol.

The Discovery Service is used by various Ubiquiti networking gear. The Ubiquiti Discovery Tool sends a 4 byte payload of \x01\0\0\0 and devices with the service will respond with hostname, model, firmware, MAC addresses, IP Addresses, etc.

v1 output

PORT      STATE SERVICE            REASON       VERSION
10001/udp open  ubiquiti-discovery udp-response Ubiquiti Discovery Service (v1 protocol)

v2 output

PORT      STATE SERVICE            REASON       VERSION
10001/udp open  ubiquiti-discovery udp-response Ubiquiti Discovery Service (v2 protocol)

This is related to PR #1457

Context: https://blog.rapid7.com/2019/02/01/ubiquiti-discovery-service-exposures/

If there aren't any objections or changes requested I will commit this code and the corresponding Changelog entry this weekend.

[TomSellers]

@dmiller-nmap - I added an entry to nmap-payloads for the v1 protocol. I'd add one for v2 but it appears you can only have one entry in nmap-payloads per port. I think this is because the port is used as the key.

nmap/payload.cc

Lines 352 to 358 in a0418c0

	for (p = 0; p < count; p++) {
	struct proto_dport key(IPPROTO_UDP, ports[p]);
	struct payload payload;
	payload.data = payload_data;
	payloads[key] = payload;
	}

[TomSellers]

Additional examples that show short model name. This output aligns with output from the script.

Version 1

PORT      STATE SERVICE            REASON              VERSION
10001/udp open  ubiquiti-discovery udp-response ttl xx Ubiquiti Discovery Service (v1 protocol, ERPro-8)
10001/udp open  ubiquiti-discovery udp-response ttl xx Ubiquiti Discovery Service (v1 protocol, ER-X)
10001/udp open  ubiquiti-discovery udp-response ttl xx Ubiquiti Discovery Service (v1 protocol, WOM5AMiMo)
10001/udp open  ubiquiti-discovery udp-response ttl xx Ubiquiti Discovery Service (v1 protocol, P5B-300)
10001/udp open  ubiquiti-discovery udp-response ttl xx Ubiquiti Discovery Service (v1 protocol, AirCam)
10001/udp open  ubiquiti-discovery udp-response ttl xx Ubiquiti Discovery Service (v1 protocol, NBE-5AC-19)

PORT      STATE SERVICE            REASON              VERSION
10001/udp open  ubiquiti-discovery udp-response ttl xx Ubiquiti Discovery Service (v1 protocol, AirCamDome)
Service Info: CPE: cpe:/h:ubnt:aircam_dome:

Version 2, some with software version

PORT      STATE SERVICE            REASON       VERSION
10001/udp open  ubiquiti-discovery udp-response Ubiquiti Discovery Service (v2 protocol, UCK software ver. 5.9.29)
10001/udp open  ubiquiti-discovery udp-response Ubiquiti Discovery Service (v2 protocol, UCK-v2 software ver. 5.9.29)
10001/udp open  ubiquiti-discovery udp-response Ubiquiti Discovery Service (v2 protocol, UCK-v3 software ver. 5.9.29)