Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-grep.nse bug fix (http-grep.nse is not working properly. line 159 and 160. there is a bug if doubled is greater than 9) #1932

Closed
wants to merge 13 commits into from

Conversation

@ColleenLee1102
Copy link

ColleenLee1102 commented Feb 22, 2020

fix solution for the bug I reported earlier

@ColleenLee1102 ColleenLee1102 changed the title Http grep bug http-grep.nse bug fix (http-grep.nse is not working properly. line 159 and 160. there is a bug if doubled is greater than 9) Feb 22, 2020
@nnposter

This comment has been minimized.

Copy link

nnposter commented Mar 1, 2020

This is a very good find. Thank you for reporting it.

The bug is a side effect of moving from Lua 5,2 to 5.3. Your PR would indeed rectify the bug but the original code was unnecessarily complex in the first place so the entire function was refactored instead. The code has been commited as r37912 and you are still being credited in the changelog.

@nnposter nnposter self-assigned this Mar 1, 2020
@nnposter nnposter added bug NSE labels Mar 1, 2020
@nmap-bot nmap-bot closed this in 44d7dbc Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.