Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces legacy API URL, encode post request in json and parse response for result. Fixes #1474 #2565

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

varuuntiwari
Copy link

Tested the JSON request by printing out the generated body and running on Postman, giving accurate responses back from API. However, some points are left:

  • An issue remains, which is testing it as a NSE script since the Nmap distribution installed in my system fails to support SSL somehow.
  • The API only accepts HTTPS connections even though the URL is given as http;//, which makes it tricky to test it without removing nmap and fixing the issue with SSL in my system.

The SSL problem is related to a single system, so I have pushed this branch in confidence that it works based on external tests. In the meantime, this commit is expected to fix the issue or even help others working on the same issue.

@varuuntiwari varuuntiwari changed the title Replaces legacy API URL, encode post request in json and parse response for result. Replaces legacy API URL, encode post request in json and parse response for result. Fixes #1474 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant