Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix names of RC2 cipher suites in sslv2.nse #314

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

bbc2 commented Feb 27, 2016

The previous naming for cipher suite 0x040080 was wrong according to OpenSSL and a draft specification. It is an export suite but its name did not reflect that.

This also removes the extra "CBC_" in both RC2 cipher suites as it seems more consistent with other names, the specification and OpenSSL.

As the names came from Wireshark, the same issue was reported to them.

Fix names of RC2 cipher suites in sslv2.nse
The previous naming for suite 0x040080 was wrong according to [1] and [2]. It
is an export suite but its name did not reflect that.

This also removes the extra "CBC_" in both RC2 cipher suites as it seems more
consistent with other names, the specification and OpenSSL.

As the names came from Wireshark, the same issue was reported to them. [3]

[1] https://github.com/openssl/openssl/blob/OpenSSL_1_0_2-stable/ssl/ssl2.h#L95
[2] http://www-archive.mozilla.org/projects/security/pki/nss/ssl/draft02.html
[3] https://code.wireshark.org/review/#/c/14197/

@nmap-bot nmap-bot closed this in 5b5524d Mar 3, 2016

@bbc2 bbc2 deleted the bbc2:fix-sslv2-rc2 branch Mar 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment