chore: lint in ci/cd

.github/workflows/main.yml

@@ -36,6 +36,9 @@ jobs:
             - name: Install modules
               run: pnpm install
 
+            - name: Linting
+              run: pnpm lint
+
             - name: Unit tests
               run: pnpm test
 

packages/react/src/context/index.tsx

@@ -23,7 +23,7 @@ export const QweryProvider: React.FC<
 		}
 
 		return createCacheProvider(store);
-	}, []);
+	}, [executionEnvironment, store]);
 
 	return (
 		<QweryContext.Provider value={cache}>{children}</QweryContext.Provider>

packages/react/src/e2e/use-qwery.csr.test.tsx

@@ -217,7 +217,7 @@ describe("useQwery csr", () => {
 						previousValue.a = 2;
 					});
 				}
-			}, [test.data]);
+			}, [test]);
 
 			return (
 				<>
@@ -261,7 +261,7 @@ describe("useQwery csr", () => {
 						previousValue.a = 2;
 					});
 				}
-			}, [test.data]);
+			}, [test]);
 
 			return (
 				<>

packages/react/src/e2e/use-qwery.ssr.test.tsx

@@ -177,7 +177,8 @@ describe("useQwery ssr", () => {
 
 export const renderSsr = (ui: React.ReactNode) => {
 	const envWindow = window;
-	/// @ts-expect-error
+	/*eslint no-global-assign: "off" */
+	/// @ts-expect-error: `window` is `undefined` on the server
 	window = undefined;
 
 	const serverRendered = ReactDOMServer.renderToString(ui);

packages/react/src/use-qwery/index.tsx

@@ -41,63 +41,63 @@ export const useQwery = <
 	>(null);
 	const abortControllerRef = React.useRef(new AbortController());
 
-	const proxiedOnChange = new Proxy(onChange, {
-		apply: (onChange, thisArg, args) => {
-			const result = Reflect.apply(onChange, thisArg, args);
-
-			if (broadcast) {
-				const createBroadcastChannel = () => {
-					if (broadcast instanceof BroadcastChannel) {
-						return broadcast;
-					}
+	useRememberScroll();
 
-					if (!queryKey) {
-						return null;
-					}
+	React.useEffect(() => {
+		const proxiedOnChange = new Proxy(onChange, {
+			apply: (onChange, thisArg, args) => {
+				const result = Reflect.apply(onChange, thisArg, args);
 
-					return new BroadcastChannel(queryKey.toString());
-				};
+				if (broadcast) {
+					const createBroadcastChannel = () => {
+						if (broadcast instanceof BroadcastChannel) {
+							return broadcast;
+						}
 
-				const channel = createBroadcastChannel();
+						if (!queryKey) {
+							return null;
+						}
 
-				channel?.postMessage(diff(args[0], args[1]));
-			}
+						return new BroadcastChannel(queryKey.toString());
+					};
 
-			if (!result) {
-				if (queryKey) {
-					context?.makeOnChange?.(queryKey)(args[0]);
+					const channel = createBroadcastChannel();
+
+					channel?.postMessage(diff(args[0], args[1]));
 				}
 
-				return void setRenderCount(renderCount => renderCount + 1);
-			}
+				if (!result) {
+					if (queryKey) {
+						context?.makeOnChange?.(queryKey)(args[0]);
+					}
 
-			if (suspense && result instanceof Promise) {
-				return (result as Promise<unknown>).catch(error => {
-					onError(args[0], args[1]);
+					return void setRenderCount(renderCount => renderCount + 1);
+				}
 
-					throw error;
-				});
-			}
+				if (suspense && result instanceof Promise) {
+					return (result as Promise<unknown>).catch(error => {
+						onError(args[0], args[1]);
 
-			return result;
-		},
-	});
+						throw error;
+					});
+				}
 
-	const proxiedOnSuccess = new Proxy(onSuccess, {
-		apply: (onSuccess, thisArg, args) => {
-			Reflect.apply(onSuccess, thisArg, args);
+				return result;
+			},
+		});
 
-			if (queryKey) {
-				context?.makeOnChange?.(queryKey)(args[0]);
-			}
+		const proxiedOnSuccess = new Proxy(onSuccess, {
+			apply: (onSuccess, thisArg, args) => {
+				Reflect.apply(onSuccess, thisArg, args);
 
-			setRenderCount(renderCount => renderCount + 1);
-		},
-	});
+				if (queryKey) {
+					context?.makeOnChange?.(queryKey)(args[0]);
+				}
 
-	useRememberScroll();
+				setRenderCount(renderCount => renderCount + 1);
+			},
+		});
 
-	React.useEffect(() => {
 		const computeInitialValue = async () => {
 			const cachedValue = queryKey
 				? context?.getCachedValue(queryKey)
@@ -206,12 +206,26 @@ export const useQwery = <
 			window.addEventListener("focus", onWindowFocus);
 		}
 
+		const sendAbortSignal = abortControllerRef.current.abort;
+
 		return () => {
 			window.removeEventListener("focus", onWindowFocus);
 			unsubscribe();
-			abortControllerRef.current.abort();
+			sendAbortSignal();
 		};
-	}, []);
+	}, [
+		context,
+		debug,
+		initialValue,
+		onError,
+		queryKey,
+		refetchOnWindowFocus,
+		subscribe,
+		suspense,
+		broadcast,
+		onChange,
+		onSuccess,
+	]);
 
 	React.useDebugValue(renderCount);
 

packages/react/src/use-remember-scroll/index.tsx

@@ -44,5 +44,5 @@ export const useRememberScroll = () => {
 		return () => {
 			window.removeEventListener("scroll", onScroll);
 		};
-	}, []);
+	}, [executionEnvironment]);
 };

packages/react/tsconfig.json

@@ -19,7 +19,7 @@
 		"noUnusedLocals": true,
 		"noUnusedParameters": true,
 		"noFallthroughCasesInSwitch": true,
-		"noImplicitAny": false,
+		"noImplicitAny": false
 	},
 	"include": ["react/src"],
 	"exclude": ["react/src/e2e"],