Skip to content

Commit

Permalink
kernel_patch_verify: allow kmake to do word splitting
Browse files Browse the repository at this point in the history
More issues with quoting variables that are meant to be split up on
usage.

KP_PARAMS takes multiple parameters, but gets quoted out.. and similar
issues with other variables.

Add Documentation around the same not to allow the next person to come
and quote things up.

Fixes: eeac60b kernel_patch_verify: quote damn near everything

Reported-by: Michael Nemanov <michael.nemanov@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
  • Loading branch information
nmenon committed May 17, 2024
1 parent ee68e47 commit 3e8da66
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions kernel_patch_verify
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,13 @@ if [ -z "$KP_TARGETS" ]; then
fi

kmake_single() {
make "$KM_A" "$KP_PARAMS" "$KM_C" "$KM_L" -j1 $@
# XXX: kmake operations depend on variable expansion- do not quote variables here.
make $KM_A $KP_PARAMS $KM_C $KM_L -j1 $@
}

kmake() {
make "$KM_A" "$KP_PARAMS" "$KM_C" "$KM_L" -j"$KM_CPUS" $@
# XXX: kmake operations depend on variable expansion- do not quote variables here.
make $KM_A $KP_PARAMS $KM_C $KM_L -j"$KM_CPUS" $@
}

###################
Expand Down

0 comments on commit 3e8da66

Please sign in to comment.