Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaled output messes up bar #2

Open
dkwo opened this issue May 30, 2024 · 2 comments
Open

scaled output messes up bar #2

dkwo opened this issue May 30, 2024 · 2 comments

Comments

@dkwo
Copy link

dkwo commented May 30, 2024

Thanks for tagging a new release, and allowing build with 0.12 zig.
I build and tried this on void linux, and it looks and feels quite nice.

One issue I encounter is that, for scaled output, the bar is messed up,
namely there's one more black bar below it.
By scaled, I mean wlr-randr --output eDP-1 --scale 2 in river init.
Also, it'd be nice to have a -Dpie configure option, to produce pie executables.

Finally, what are your thoughts about implementing a config file?
instead of piping the output and/or poling frequently, the config file could contain
the actual command(s) I want to run, e.g date '+%a %Y-%m-%d %H:%M',
and their polling time, e.g. 5s,
as well as possibly the various options for font, color, etc,
similar to dwm but without the need to rebuild it.

@nmeum
Copy link
Owner

nmeum commented Jun 1, 2024

Hi, thanks for the report! Lack of support for scaled outputs is currently a known limitation (levee, on which creek is based, didn't properly support this originally either). I don't use scaled outputs right now, hence it hasn't been a priority for me personally to address this. Additionally, it's not that easy to support in the current code base. One major problem in this regard is the lack of a good abstraction for fcft+pixman within the code base. Essentially, all calculations in src/render.zig would therefore have to be adjusted in a way that they take the scale factor into account. Probably, it would be good to first refactor the code in a way that provides a good widget/drawing abstraction on top of fcft and pixman, which could then be enhanced to take the scale factor into account. Patches implementing that are more than welcome.

I like the -Dpie suggestion, I will add that in a second.

I am personally not a fan of config file support, but feel free to maintain you own fork if this is of interest to you.

@dkwo
Copy link
Author

dkwo commented Jun 1, 2024

I see, thanks for the explanation. I understand your point about config.

nmeum added a commit that referenced this issue Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants