Skip to content

Commit

Permalink
style and docs: run devtools::document() and styler::style_pkg()
Browse files Browse the repository at this point in the history
  • Loading branch information
k-doering-NOAA committed Feb 2, 2024
1 parent 8073027 commit f594bb1
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 14 deletions.
8 changes: 4 additions & 4 deletions R/calc_F.R
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ get_F <- function(timeseries, fleetnames, fleetnames_all) {
# feed back as a named vector sorted by fleet, then season. Names are the
# same as in the PARAMETERS section of report.sso
init_F <- init_F[order(init_F[, "Fleet"], init_F[, "Seas"]), ]

# edit to account for fleets of type==3 in list of fleets
fleetnumbers = which(fleetnames_all %in% fleetnames)
fleetnames_df<- data.frame(Fleet=fleetnumbers, fleetname=fleetnames)
fleetnumbers <- which(fleetnames_all %in% fleetnames)
fleetnames_df <- data.frame(Fleet = fleetnumbers, fleetname = fleetnames)

init_F <- merge(init_F, fleetnames_df)
init_F_names <- paste0(
"InitF_seas_", init_F[["Seas"]], "_flt_", init_F[["Fleet"]],
Expand Down
2 changes: 1 addition & 1 deletion R/initOM.R
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ create_OM <- function(OM_out_dir,
timeseries = outlist[["timeseries"]],
fleetnames = dat[["fleetinfo"]][dat[["fleetinfo"]][["type"]] %in% c(1, 2), "fleetname"],
fleetnames_all = dat[["fleetinfo"]][["fleetname"]] # add to account for fleets type=3
)
)

# SINGLE_RUN_MODS:
update_F_years <- (dat[["endyr"]] + 1):(dat[["endyr"]] + nyrs)
Expand Down
17 changes: 10 additions & 7 deletions R/initOM_create_devs_list.R
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,11 @@ match_parname <- function(list_pars, parlist) {
)
)
## Edit to allow for recdevs labeled recdev2 not recdev1
rdnme<-names(parlist)[grepl("recdev", names(parlist))][1]
par_name_tbl <- rbind(par_name_tbl, data.frame(pars = "rec_devs",
obj = rdnme))
rdnme <- names(parlist)[grepl("recdev", names(parlist))][1]
par_name_tbl <- rbind(par_name_tbl, data.frame(
pars = "rec_devs",
obj = rdnme
))
par_name_tbl <- rbind(par_name_tbl, data.frame(pars = "impl_error", obj = NA))
if (isTRUE(list_pars == "all")) {
# TODO: consider which parameters should be included in the "all" option.
Expand Down Expand Up @@ -444,11 +446,12 @@ calc_par_trend <- function(val_info,
if (isTRUE(!is.na(val_info[val_info[["ts_param"]] == val_line, "first_yr_averaging"]) &
!is.na(val_info[val_info[["ts_param"]] == val_line, "last_yr_averaging"]))) {
if (parname == "rec_devs") {

# EDITED bc par file labeled "recdev2" NOT "recdev1"
rdnme<-names(parlist)[grepl("recdev", names(parlist))][1]
tmp_vals <- data.frame(yrs = parlist[[rdnme]][, 1],
rec_devs = parlist[[rdnme]][, 2])
rdnme <- names(parlist)[grepl("recdev", names(parlist))][1]
tmp_vals <- data.frame(
yrs = parlist[[rdnme]][, 1],
rec_devs = parlist[[rdnme]][, 2]
)
tmp_vals_2 <- data.frame(yrs = vals_df[["yrs"]], rec_devs = vals_df[["rec_devs"]])
tmp_vals <- rbind(tmp_vals, tmp_vals_2)
to_include <- which(tmp_vals[["yrs"]] >= val_info[val_info[["ts_param"]] == val_line, "first_yr_averaging"] &
Expand Down
2 changes: 1 addition & 1 deletion man/get_F.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/testthat/test-calc_F.R
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ test_timeseries <- data.frame(
test_fleetnames <- c("Fishery", "Survey")

test_that("get_F works with multi yrs, fleets, and seasons", {
F_list <- get_F(timeseries = test_timeseries, fleetnames = test_fleetnames, fleetnames_all=test_fleetnames)
F_list <- get_F(timeseries = test_timeseries, fleetnames = test_fleetnames, fleetnames_all = test_fleetnames)

expect_true(NROW(F_list[["F_df"]]) == nfleets * NROW(test_timeseries))
expect_true(length(F_list) == 4) # b/c 4 components of output
Expand Down

0 comments on commit f594bb1

Please sign in to comment.