Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

improve scripts/ develop github actons for updating user_examples and test_models #39

Closed
k-doering-NOAA opened this issue Apr 12, 2022 · 3 comments
Assignees

Comments

@k-doering-NOAA
Copy link
Collaborator

k-doering-NOAA commented Apr 12, 2022

Currently, there are R scripts for updating the models in user-examples and test-models upon each release. These are run locally, but the scripts require some manual changes and take local computing power to run. I feel it takes me longer than it should to run this because I have to refamiliarize myself with the script each time.

Another issue to updating is not well documented, because the script requires some manual changes and doesn't provide good instructions on how to run it. This is not helpful if anyone besides me needs to do the updating.

It may be nicer to fully automate these in github actions. The steps would be:

  1. Download the latest SS3 executable
  2. Run a streamlined version of the script that doesn't require manual input changes. This would update model input and output files.
  3. Delete any files that shouldn't be committed
  4. Open a pull request with the changes to the repository for review.

A tag would also need to be added once it is merged in, but this step may need to be left as manual.

@k-doering-NOAA k-doering-NOAA self-assigned this Apr 12, 2022
@k-doering-NOAA
Copy link
Collaborator Author

Another reason to fully automate updating the test results on each release are that the compiler/os is then different, which can lead to some small differences in model results. It would be cleaner to run the model updates on ubuntu since that is the system used to run the stock synthesis regression tests.

@k-doering-NOAA
Copy link
Collaborator Author

These scripts are linked in nmfs-ost/ss3-source-code#352 (comment)

@k-doering-NOAA k-doering-NOAA removed their assignment Jul 29, 2022
@e-perl-NOAA
Copy link
Collaborator

There are now github actions for updating these the user-example models and the test models in the respective repositories.
user-example models github action
test models github action

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants