Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #40 #42

Merged
merged 1 commit into from Dec 28, 2020
Merged

Resolve #40 #42

merged 1 commit into from Dec 28, 2020

Conversation

Ced2142
Copy link
Contributor

@Ced2142 Ced2142 commented Dec 28, 2020

This returns the whole mac address object. The following attributes are returned now:

 "macaddress": {
   "addr": "AA:AA:AA:AA:AA:AA",
   "addrtype": "mac",
   "vendor": "Some Vendor"
  }

The addrtype attribute is useless but the vendor attribute it pretty useful in my opinion. If only the mac address is wanted, the PR can be changed to only return the addr value with .get('addr') in the return statement of parse_mac_address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants