Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix epochMilliseconds argument; minor README updates #151

Merged
merged 5 commits into from
May 14, 2021

Conversation

piperchester
Copy link
Contributor

@piperchester piperchester commented Jan 11, 2021

Love this project @nmn, thanks for authoring it! Was using it and wanted to contribute a couple small updates.

Notably:

  • Moved CHANGELOG to its own file
  • Fixed the epochMilliseconds argument in docs, and in code to add two lls
  • Misc. formatting
  • Alphabetized npm scripts

README.md Outdated Show resolved Hide resolved
@piperchester piperchester changed the title docs(*): minor readme and changelog updates Fix epochMilliseconds argument; minor README updates Jan 11, 2021
README.md Show resolved Hide resolved
Copy link
Owner

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the typo fix for EpochMiliseconds as that creates a breaking change?

src/formatters/buildFormatter.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@nmn nmn merged commit e0467ca into nmn:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants