-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with image generation #90
Comments
This looks to me like an artifact of the local seam leveling. Could you show me the wireframe of at one of these edges? Best |
Hi @nmoehrle thanks for your reply. Best |
Open the textured mesh (.obj) from the odm_texturing folder in MeshLab, there’s an option to enable wireframe view there. I’ve also seen these artifacts before, would love to learn more about possible causes and how to prevent them. |
Ok, I will try, thanks a lot @pierotofy |
Hi, I made the procedure to access the wireframe The 3d image showing a problem area and the wireframe. |
@juvinski for the future, use "flat lines" and toggle the lights. Here's a good screenshot. A few other artifacts from the same dataset. |
Really nice @pierotofy |
I don't have an explanation for these artifacts, my first guess was an issue with the local seam leveling but those artifact would appear along mesh edges. Nothing within the algorithm should change the input images in such a way. I hope that I find the time to investigate this during the holidays. |
Please let me know if I can provide you with data or ways to reproduce it. Happy holidays! |
Me too, I have three or four datasets with same problem |
Is one of these datasets small enough that you can bisect the issue? Was there a version of texrecon that did not produce these issues? |
I remember first seeing this problem about 8 months ago. It's possible that it worked before, but I wouldn't be able to tell. @juvinski ? Tomorrow I'll try to put together a reproducible dataset. |
@juvinski would you be willing to share one of your datasets' images on google drive? |
hi @pierotofy and @nmoehrle , I don't remember any dataset with this problems since the datasets O processed since November. Best regards |
Ok here's a full, reproducible test case: Texrecon version is from the OpenDroneMap fork (https://github.com/OpenDroneMap/mvs-texturing/) which is almost on par with the current master. Dataset with mesh, images and visualsfm file: https://drive.google.com/open?id=12rrV51VSwXvQgXf-TbZBubwN9i-YMZ8w
|
Btw, |
Found a smaller reproducible dataset (18 images) which might be easier to work with. https://drive.google.com/open?id=1KUPVMyGwStRirXJmoC6BNoiwFp2pGLTF
Top right corner shows: |
I finally managed to look into this and the artifact is introduced during the global seam leveling, if the global seam leveling is disabled ( |
I just had a result where everything was pink like yours. I initially thought that was the original color you fed into the algorithm, did the algorithm distort the color towards pink? |
You mean the "subset" dataset? The images are already pinkish due to the camera filter that was used to take the images. |
Oh I see, no I've never seen that type of pink output. ^_^ |
Hi, |
Hi, this dataset can be used. https://drive.google.com/drive/folders/1DYESz3VnH95kPolA-Qhm1rx4OaZfCJhk?usp=sharing Best regards. |
Ok so the issue arises due to the jpeg compression of the undistored images. The current implementation assumes a pitch black (RGB(0,0,0)) border within undistorted images and calculates a validity mask from it. In a lossy compressed format like jpeg the border is not pitch black and thus regions that should be invalid might be classified as valid and used in the reconstruction. The artifacts we see are the undistortion borders of images. My previous assessment that the the problem is caused by the global seam leveling was wrong -- there was a race condition when using data costs or the labeling of a previous run ( I am reluctant to increase the threshold although this would fix this particular problem because it might cause other issues. Is it possible for you to write out undistorted images in a lossless format? |
Thanks for taking the time to look into this @nmoehrle! I think we can export the images in a lossless format, I will discuss it with the OpenDroneMap team. |
Hi @nmoehrle, I'm generating undistorted images in png format( and testing compression from 0 to 9). |
Oh that's surprising - can you provide the dataset that gives you five slashes? |
in true is the same dataset - I was comparing the image convertion to see what results or differences I will get. This is the dataset. https://drive.google.com/open?id=1y2G1Et72H4zsVU0EVNvypZVAtk88Y-Yw |
Hi @nmoehrle , I discovered something more about this issue. Best regards. |
@juvinski you should try to provide a reproducible dataset (images, nvm file, etc.) so that we can try to identify the problem further. Without it it's a bit difficult 👍 |
Has anyone ever looked deeper into this and found out something new? Using some lossless compression like png fixed a lot of issues, but still some remain as for @juvinski . Edit: Unlike mentioned above, I could resolve quite a few/all of the left-over artifacts by using area instead of gmi as data term. Why exactly this caused them I can't tell (yet), but I intuitively I'm not surprised that it might cause some local favoring of strong gradients (of maybe a slightly misaligned camera view?) |
Hi,
I'm using ODM and after some map generation, there is an issue with the final products. On the final image - orthomosaic - there are lines like that:
How can I debug or try to see what is been done by mvs-texturing to figure out what is the cause of this error - the source images doesn't have this line BTW.
Best regards
The text was updated successfully, but these errors were encountered: