Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't unzip Brian Gladman AES protected file with Apple CommonCrypto #397

Closed
Coeur opened this issue May 21, 2019 · 1 comment
Closed

Can't unzip Brian Gladman AES protected file with Apple CommonCrypto #397

Coeur opened this issue May 21, 2019 · 1 comment
Labels
encryption Encryption/decryption issue fixed Issue or bug has been fixed

Comments

@Coeur
Copy link
Contributor

Coeur commented May 21, 2019 •
edited

This is a follow up of ZipArchive/ZipArchive#516

  1. We create a BRG AES protected file (using ZipArchive based on minizip 1.2), with password "got":
    v1.zip

  2. We build minizip 2.8.7 with Apple Crypt:

$ cmake . -DMZ_BZIP2=OFF -DMZ_LZMA=OFF -DMZ_BUILD_TEST=ON
$ cmake --build .
  1. We attempt to unzip the file:
$ ./minizip -x -p got v1.zip 
Minizip 2.8.7 - https://github.com/nmoinvaz/minizip
---------------------------------------------------
-x -p *** v1.zip 
Archive v1.zip
Extracting 1.md
Error -3 saving entries to disk v1.zip
Error -105 closing archive for reading

The error is produced on the following line: https://github.com/nmoinvaz/minizip/blob/64c4c7f868467ca21434cced2a418f21d3c6c664/mz_strm_zlib.c#L181
nmoinvaz added a commit that referenced this issue May 21, 2019
@nmoinvaz
Fixed AES not working in correct mode when using CommonCrypto. #397, #…
641b0bc 
…398
@nmoinvaz
Copy link
Member

That should fix it. Let me know if you have problems.

@Coeur Coeur closed this as completed May 22, 2019
@nmoinvaz nmoinvaz added 2.0 encryption Encryption/decryption issue fixed Issue or bug has been fixed labels May 23, 2019
@nmoinvaz nmoinvaz mentioned this issue Feb 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encryption Encryption/decryption issue fixed Issue or bug has been fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Coeur @nmoinvaz