Remove direct dependencies on IBM Dump and Oracle Attach APIs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom source. 2. Remove direct dependencies on IBM Dump and Oracle Attach APIs and instead ask for heapdumps through reflection.
|
This seems like a sensible addition! |
hpresnall
pushed a commit
that referenced
this pull request
Feb 10, 2014
Moved heap dump code to use reflection and remove compile time dependency on specific JVMs. Updated README to markdown; added link to website and 'build from source' instructions.
|
Merged fix but updated changes to use the |
|
Makes sense, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just used this tool for the first time based on someone's recommendation, and it was absolutely wonderful! Thank you so much.
I found building it slightly confusing because it depends on both the IBM Dump API and Oracle Attach APIs, which means one would need to use the IBM JDK to compile and and reference the Oracle tools.jar. This pull request simplifies this by just calling these methods through reflection. I also changed README to a markdown file and added instructions on how to compile from source.