tests: clean up expressions in clean.tcl

nmoroze · Apr 1, 2024 · 126a4f3 · 126a4f3
1 parent f2bd514
commit 126a4f3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 30 deletions.
diff --git a/tests/data/clean.tcl b/tests/data/clean.tcl
@@ -1,9 +1,9 @@
 for {set i 1} {$i < 100} {incr i} {
-    if {[expr $i % 15] == 0} {
+    if {$i % 15 == 0} {
         puts "FizzBuzz"
-    } elseif {[expr $i % 3] == 0} {
+    } elseif {$i % 3 == 0} {
         puts "Fizz"
-    } elseif {[expr $i % 5] == 0} {
+    } elseif {$i % 5 == 0} {
         puts "Buzz"
     } else {
         puts $i

diff --git a/tests/test_parser.py b/tests/test_parser.py
@@ -264,16 +264,13 @@ def test_clean_tcl():
                     BareWord("if"),
                     BracedExpression(
                         BinaryOp(
-                            CommandSub(
-                                Command(
-                                    BareWord("expr"),
-                                    VarSub("i"),
-                                    BareWord("%"),
-                                    BareWord("15"),
-                                )
+                            VarSub("i"),
+                            BareWord("%"),
+                            BinaryOp(
+                                BareWord("15"),
+                                BareWord("=="),
+                                BareWord("0"),
                             ),
-                            BareWord("=="),
-                            BareWord("0"),
                         ),
                     ),
                     Script(
@@ -282,16 +279,13 @@ def test_clean_tcl():
                     BareWord("elseif"),
                     BracedExpression(
                         BinaryOp(
-                            CommandSub(
-                                Command(
-                                    BareWord("expr"),
-                                    VarSub("i"),
-                                    BareWord("%"),
-                                    BareWord("3"),
-                                )
+                            VarSub("i"),
+                            BareWord("%"),
+                            BinaryOp(
+                                BareWord("3"),
+                                BareWord("=="),
+                                BareWord("0"),
                             ),
-                            BareWord("=="),
-                            BareWord("0"),
                         ),
                     ),
                     Script(
@@ -300,16 +294,13 @@ def test_clean_tcl():
                     BareWord("elseif"),
                     BracedExpression(
                         BinaryOp(
-                            CommandSub(
-                                Command(
-                                    BareWord("expr"),
-                                    VarSub("i"),
-                                    BareWord("%"),
-                                    BareWord("5"),
-                                )
+                            VarSub("i"),
+                            BareWord("%"),
+                            BinaryOp(
+                                BareWord("5"),
+                                BareWord("=="),
+                                BareWord("0"),
                             ),
-                            BareWord("=="),
-                            BareWord("0"),
                         ),
                     ),
                     Script(