Refactor/make toISO calls typesafe (#41)

* chore: bump libs

* chore: remove any cast

* refactor: make toISO usage typesafe

package.json

@@ -27,7 +27,7 @@
         "@js-soft/eslint-config-ts": "^1.6.6",
         "@js-soft/license-check": "^1.0.9",
         "@types/jest": "^29.5.12",
-        "@types/node": "^20.11.20",
+        "@types/node": "^20.11.22",
         "copy-webpack-plugin": "^12.0.2",
         "enhanced-publish": "^1.1.2",
         "eslint": "^8.57.0",

packages/runtime/package.json

@@ -68,7 +68,7 @@
         "@nmshd/consumption": "3.9.5",
         "@nmshd/content": "2.8.7",
         "@nmshd/crypto": "2.0.6",
-        "@nmshd/transport": "2.3.3",
+        "@nmshd/transport": "2.3.4",
         "ajv": "^8.12.0",
         "ajv-errors": "^3.0.0",
         "ajv-formats": "^2.1.1",

packages/runtime/test/consumption/iqlQuery.test.ts

@@ -90,7 +90,7 @@ describe("IQL Query", () => {
                         }
                     }
                 ],
-                expiresAt: DateTime.now().plus({ hour: 1 }).toISO() as any
+                expiresAt: DateTime.now().plus({ hour: 1 }).toISO()
             },
             peer: (await rTransportServices.account.getIdentityInfo()).value.address
         });

packages/transport/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nmshd/transport",
-    "version": "2.3.3",
+    "version": "2.3.4",
     "description": "The transport library handles backbone communication and content encryption.",
     "homepage": "https://enmeshed.eu",
     "repository": {
@@ -93,7 +93,7 @@
         "@types/json-stringify-safe": "^5.0.3",
         "@types/lodash": "^4.14.202",
         "@types/luxon": "^3.4.2",
-        "@types/qs": "^6.9.11",
+        "@types/qs": "^6.9.12",
         "@types/uuid": "^9.0.8",
         "expect": "^29.7.0",
         "ts-mockito": "^2.6.1"

packages/transport/src/core/types/CoreDate.ts

@@ -15,8 +15,7 @@ export class CoreDate extends CoreSerializable {
     }
 
     public get date(): string {
-        if (!this.dateTime.isValid) throw new TransportError("The date is invalid.");
-        return this.dateTime.toISODate()!;
+        return this.asValidDateTime.toISODate();
     }
 
     public constructor(dateTime: DateTime = DateTime.utc()) {
@@ -134,27 +133,28 @@ export class CoreDate extends CoreSerializable {
      * Creates an ISO String.
      */
     public override toString(): string {
-        if (!this.dateTime.isValid) throw new TransportError("The date is invalid.");
-        return this.dateTime.toISO()!;
+        return this.asValidDateTime.toISO();
     }
 
     public toISOString(): string {
-        if (!this.dateTime.isValid) throw new TransportError("The date is invalid.");
-        return this.dateTime.toISO()!;
+        return this.asValidDateTime.toISO();
     }
 
     public override toLocaleString(): string {
         return this.dateTime.toLocaleString();
     }
 
     public override toJSON(): string {
-        if (!this.dateTime.isValid) throw new TransportError("The date is invalid.");
-        return this.dateTime.toISO()!;
+        return this.asValidDateTime.toISO();
     }
 
     public override serialize(): string {
+        return this.asValidDateTime.toISO();
+    }
+
+    private get asValidDateTime(): DateTime<true> {
         if (!this.dateTime.isValid) throw new TransportError("The date is invalid.");
-        return this.dateTime.toISO()!;
+        return this.dateTime as DateTime<true>;
     }
 
     protected static override preFrom(value: any): any {
@@ -183,7 +183,7 @@ export class CoreDate extends CoreSerializable {
             return DateTime.fromISO(value, { zone: "utc" }).toUTC();
         }
 
-        throw new TransportError("The provided object is invalid cannot be deserialized.");
+        throw new TransportError("The provided object is invalid and cannot be deserialized.");
     }
 
     public static from(value: ICoreDate | string | number): CoreDate {