Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app label missing at daemonset #476

Closed
qinqon opened this issue Mar 31, 2020 · 5 comments
Closed

app label missing at daemonset #476

qinqon opened this issue Mar 31, 2020 · 5 comments

Comments

@qinqon
Copy link
Member

qinqon commented Mar 31, 2020

What happened:
In case kubernetes-nmstate is deployed as past of bigger product within its namespace (like HCO) and filtering kubernet-nmstate daemonset is needed (like e2e test checking knmstate is up and running) we have to filter by pod name string or pod templates, adding the app=kubernetes-nmstate labels at daemonset make this much more convenient.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • NodeNetworkState on affected nodes (use kubectl get nodenetworkstate <node_name> -o yaml):
  • Problematic NodeNetworkConfigurationPolicy:
  • kubernetes-nmstate image (use kubectl get pods --all-namespaces -l app=kubernetes-nmstate -o jsonpath='{.items[0].spec.containers[0].image}'):
  • NetworkManager version (use nmcli --version)
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Others:
@qinqon
Copy link
Member Author

qinqon commented Apr 1, 2020

/good-first-issue

@qinqon
Copy link
Member Author

qinqon commented Apr 1, 2020

/bug

@qinqon
Copy link
Member Author

qinqon commented Apr 1, 2020

/label kind/bug

@qinqon
Copy link
Member Author

qinqon commented Apr 1, 2020

/kind bug

@kubevirt-bot
Copy link
Collaborator

@qinqon: The label(s) kind/bug cannot be applied, because the repository doesn't have them

In response to this:

/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinqon qinqon closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants