Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels for pod security standards #1093

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

creydr
Copy link
Collaborator

@creydr creydr commented Jun 2, 2022

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What this PR does / why we need it:
This PR adds the pod security standard (PSS) labels to the namespace(s).
As the operator itself does not require any privileged permissions, by default the operator namespace will have the restricted PSS. When the handler gets installed, this will "update" to the privileged PSS.
In addition the security context of the operator deployment was adjusted to not run the container as root (I didn't see a need for being root in the operator container) and changed the uid in the dockerfile to 1000.

Special notes for your reviewer:

Release note:

Add pod security standard labels

This commit adds the restricted pod security standard labels to the
operators namespace. Since the handler requires the privileged PSS label
the operator will apply this label to the namespace where the handler
will be installed.

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement labels Jun 2, 2022
@kubevirt-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@creydr
Copy link
Collaborator Author

creydr commented Jun 2, 2022

/test all

@creydr creydr marked this pull request as ready for review June 2, 2022 11:24
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2022
@kubevirt-bot kubevirt-bot requested a review from qinqon June 2, 2022 11:24
@creydr
Copy link
Collaborator Author

creydr commented Jun 2, 2022

/assign @qinqon @rhrazdil @phoracek

@creydr
Copy link
Collaborator Author

creydr commented Jun 2, 2022

/assign @cybertron

@kubevirt-bot
Copy link
Collaborator

@creydr: GitHub didn't allow me to assign the following users: cybertron.

Note that only nmstate members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @cybertron

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Collaborator Author

creydr commented Jun 2, 2022

/cc @cybertron

@kubevirt-bot
Copy link
Collaborator

@creydr: GitHub didn't allow me to request PR reviews from the following users: cybertron.

Note that only nmstate members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @cybertron

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinqon
Copy link
Member

qinqon commented Jun 6, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@kubevirt-bot
Copy link
Collaborator

kubevirt-bot commented Jun 6, 2022

@creydr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 2ae07a8 link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@creydr
Copy link
Collaborator Author

creydr commented Jun 7, 2022

/retest-required

@kubevirt-bot kubevirt-bot merged commit 8f9f486 into nmstate:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants