Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control plane, Assign Priority class to pods #777

Merged
merged 1 commit into from Jun 17, 2021
Merged

Control plane, Assign Priority class to pods #777

merged 1 commit into from Jun 17, 2021

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Jun 16, 2021 •
edited

Add system-node-critical to nmstate-handler,
since this pod should run on each node,

Add system-cluster-critical to nmstate-webhook
and to nmstate-cert-manager pods,
since those pods aren't bound to a specific node,
yet those are important control plane pods.

This will make the control plane less sensitive to preemption
than user workloads.

Signed-off-by: Or Shoval oshoval@redhat.com

None

@oshoval
Control plane, Assign Priority class to pods
938263c 
Add system-node-critical to nmstate-handler,
since this pod should run on each node,

Add system-cluster-critical to nmstate-webhook
and to nmstate-cert-manager pods,
since those pods aren't bound to a specific node,
yet those are important control plane pods.

This will make the control plane less sensitive to preemption
than user workloads.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 16, 2021
@kubevirt-bot
Copy link
Collaborator

Hi @oshoval. Thanks for your PR.

I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS labels Jun 16, 2021
@oshoval
Copy link
Collaborator Author

oshoval commented Jun 16, 2021

@qinqon need ok to test please and review if possible

@phoracek
Copy link
Member

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
@oshoval
Copy link
Collaborator Author

oshoval commented Jun 16, 2021

I don't think the failure is due to this PR

/retest

@qinqon
Copy link
Member

qinqon commented Jun 17, 2021

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@kubevirt-bot kubevirt-bot merged commit ffef75b into nmstate:main Jun 17, 2021
@oshoval oshoval mentioned this pull request Jun 17, 2021
Merged
@oshoval
Copy link
Collaborator Author

oshoval commented Jun 23, 2021

/cherry-pick release-0.47

@kubevirt-bot
Copy link
Collaborator

@oshoval: only nmstate org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-0.47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oshoval oshoval mentioned this pull request Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek Awaiting requested review from phoracek

@yboaron yboaron Awaiting requested review from yboaron

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oshoval @kubevirt-bot @phoracek @qinqon