Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.47 fix dockerfile openshift #821

Merged
merged 1 commit into from Sep 15, 2021
Merged

Release 0.47 fix dockerfile openshift #821

merged 1 commit into from Sep 15, 2021

Conversation

rhrazdil
Copy link
Collaborator

@rhrazdil rhrazdil commented Sep 7, 2021

Cherry-pick of #817

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What this PR does / why we need it:

Special notes for your reviewer:
Should only be merged if #820 is accepted

Release note:

NONE

@kubevirt-bot kubevirt-bot added kind/bug release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 7, 2021
@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Sep 7, 2021
@rhrazdil rhrazdil changed the base branch from main to release-0.47 September 7, 2021 11:19
@rhrazdil
Fix Dockerfile.openshift (nmstate#817)
ce2582c 
Dockerfile still attempty to copy build/bin directory,
but this folder has been removed.

Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
@rhrazdil rhrazdil force-pushed the release-0.47-fix-dockerfile-openshift branch from 77f1fae to ce2582c Compare September 7, 2021 11:20
@kubevirt-bot kubevirt-bot added size/XS and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Sep 7, 2021
@rhrazdil
Copy link
Collaborator Author

rhrazdil commented Sep 7, 2021

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2021
@rhrazdil
Copy link
Collaborator Author

rhrazdil commented Sep 9, 2021

#820 got merged, unholding
/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
phoracek
phoracek reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@rhrazdil
Copy link
Collaborator Author

rhrazdil commented Sep 9, 2021

/test pull-kubernetes-nmstate-e2e-operator-k8s-0.47

1 similar comment
@rhrazdil
Copy link
Collaborator Author

rhrazdil commented Sep 9, 2021

/test pull-kubernetes-nmstate-e2e-operator-k8s-0.47

@rhrazdil
Copy link
Collaborator Author

rhrazdil commented Sep 9, 2021

/retest

1 similar comment
@qinqon
Copy link
Member

qinqon commented Sep 10, 2021

/retest

@rhrazdil
Copy link
Collaborator Author

/test pull-kubernetes-nmstate-e2e-operator-k8s-0.47

@rhrazdil
Copy link
Collaborator Author

/retest

@kubevirt-bot
Copy link
Collaborator

kubevirt-bot commented Sep 15, 2021 •
edited

@rhrazdil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 77f1fae link /test pull-kubernetes-nmstate-e2e-handler-k8s-future
pull-kubernetes-nmstate-e2e-handler-k8s 77f1fae link /test pull-kubernetes-nmstate-e2e-handler-k8s
pull-kubernetes-nmstate-e2e-operator-k8s 77f1fae link /test pull-kubernetes-nmstate-e2e-operator-k8s
pull-kubernetes-nmstate-docs 77f1fae link /test pull-kubernetes-nmstate-docs
pull-kubernetes-nmstate-unit-test 77f1fae link /test pull-kubernetes-nmstate-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhrazdil
Copy link
Collaborator Author

/retest

@kubevirt-bot kubevirt-bot merged commit 959168e into nmstate:release-0.47 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek left review comments

@qinqon qinqon Awaiting requested review from qinqon

@yboaron yboaron Awaiting requested review from yboaron

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhrazdil @kubevirt-bot @qinqon @phoracek