Add handler E2E tests for static addresses and routes #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: no
kubevirt-bot
added
do-not-merge/release-note-label-needed
yboaron
force-pushed
the
test_static
branch
2 times, most recently
from
ead80a5
to
3b1d72b
Compare
kubevirt-bot
added
dco-signoff: yes
|
/release-note-none |
kubevirt-bot
added
release-note-none
|
/retest |
qinqon
requested changes
Nov 2, 2021
There was a problem hiding this comment.
Can you check if those state snippets are not already at https://github.com/nmstate/kubernetes-nmstate/blob/main/test/e2e/handler/states.go ?
Also don't export the function.
|
/retest |
qinqon
requested changes
Nov 3, 2021
Comment on lines
12
to
24
| func ipV4AddrAbsent(firstSecondaryNic, ipAddress, prefixLen string) nmstate.State { | ||
| return nmstate.NewState(fmt.Sprintf(`interfaces: | ||
| - name: %s | ||
| type: ethernet | ||
| state: up | ||
| ipv4: | ||
| address: | ||
| - ip: %s | ||
| prefix-length: %s | ||
| state: absent | ||
| enabled: false | ||
| `, firstSecondaryNic, ipAddress, prefixLen)) | ||
| } |
There was a problem hiding this comment.
Can you move this functions to test/e2e/handler/states.go ?
Signed-off-by: Yossi Boaron yboaron@redhat.com
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
rhrazdil
pushed a commit
to rhrazdil/kubernetes-nmstate
that referenced
this pull request
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yossi Boaron yboaron@redhat.com
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
This PR adds E2E static (both V4 and V6) addresses and routes tests for handler