Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handler E2E tests for DNS configuration #866

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Add handler E2E tests for DNS configuration #866

merged 1 commit into from
Nov 18, 2021

Conversation

yboaron
Copy link
Collaborator

@yboaron yboaron commented Nov 3, 2021

Is this a BUG FIX or a FEATURE ?:

/kind enhancement

What this PR does / why we need it:
This PR adds E2E DNS tests for handler

Signed-off-by: Yossi Boaron yboaron@redhat.com

@kubevirt-bot kubevirt-bot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 3, 2021
@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M labels Nov 3, 2021
@qinqon
Copy link
Member

qinqon commented Nov 4, 2021

/hold

Let's first fix dns at NNS with #867

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021
@qinqon
Copy link
Member

qinqon commented Nov 8, 2021

@yboaron can you use NNS to check now that we show the dns-resolve there ?

@yboaron yboaron changed the title [WIP] Add handler E2E tests for DNS configuration Add handler E2E tests for DNS configuration Nov 10, 2021
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@qinqon
Copy link
Member

qinqon commented Nov 11, 2021

@yboaron looks like the e2e tests are failing, can you check it out before doing any review ?

@yboaron
Copy link
Collaborator Author

yboaron commented Nov 11, 2021

@yboaron looks like the e2e tests are failing, can you check it out before doing any review ?

Hmm, I'm not sure why tests fail, on OCP (virtual baremetal deployment) both tests are green

@yboaron
Copy link
Collaborator Author

yboaron commented Nov 14, 2021

/test pull-kubernetes-nmstate-e2e-handler-k8s

@yboaron
Copy link
Collaborator Author

yboaron commented Nov 14, 2021

Seems that second (with V6 U/S servers) dns always fails while the test with V4 U/S servers is green, I assume that 'clearing' [1] DNS configuration doesn't work.

[1]
dns-resolver:
config:
state: absent
interfaces:

  • name: %s
    type: ethernet
    state: up
    %s:
    enabled: false

@yboaron
Copy link
Collaborator Author

yboaron commented Nov 16, 2021

/test pull-kubernetes-nmstate-e2e-handler-k8s

@qinqon
Copy link
Member

qinqon commented Nov 16, 2021

/hold cancel
Now the approach looks good we have to fix the CI

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2021
@qinqon
Copy link
Member

qinqon commented Nov 16, 2021

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 16, 2021
@qinqon
Copy link
Member

qinqon commented Nov 16, 2021

/lgtm
/approve

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2021
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@yboaron yboaron force-pushed the dns_test branch 2 times, most recently from c9bc962 to 142ef25 Compare November 17, 2021 11:03
@qinqon
Copy link
Member

qinqon commented Nov 17, 2021

/hold
We are going to focus the DNS test, something is fishy at CI.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
@yboaron yboaron force-pushed the dns_test branch 3 times, most recently from 433f2da to af83304 Compare November 17, 2021 14:23
qinqon
qinqon requested changes Nov 18, 2021
View reviewed changes
test/e2e/handler/dns_test.go Outdated
Comment on lines 81 to 82
serverList := dnsResolverForNode(nodes[0], "dns-resolver.running.server")
updateDesiredStateAndWait(dnsConfig(searchDomain1, searchDomain2, serverList[0], upStream1V6, "ipv6", dnsTestNic))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serverList[0] can be an IPv4 but for IPv4 you have auto-dns so it will fail since you cannot configure dns with auto-dns,

You need to pass all the list and disable auto-dns for both IPv4 and IPv6.

@yboaron yboaron force-pushed the dns_test branch 2 times, most recently from 4990932 to 5eb6038 Compare November 18, 2021 11:01
qinqon
qinqon requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit for naming.

test/e2e/handler/dns_test.go Outdated
Comment on lines 55 to 56
upStream1V4 = "8.8.9.9"
upStream1V6 = "2001:db8::1:2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
upStream1V4 = "8.8.9.9"
upStream1V6 = "2001:db8::1:2"
server1V4 = "8.8.9.9"
server1V6 = "2001:db8::1:2"

@yboaron
Add handler E2E tests for DNS configuration
b9e28df 
Signed-off-by: Yossi Boaron yboaron@redhat.com
qinqon
qinqon approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Collaborator

@yboaron: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future b9e28df link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qinqon
Copy link
Member

qinqon commented Nov 18, 2021

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
@kubevirt-bot kubevirt-bot merged commit 17c0b02 into nmstate:main Nov 18, 2021
rhrazdil pushed a commit to rhrazdil/kubernetes-nmstate that referenced this pull request Dec 6, 2021
Revert "Add handler E2E tests for DNS configuration (nmstate#866)"
6e5b16c 
This reverts commit 17c0b02.
rhrazdil pushed a commit to rhrazdil/kubernetes-nmstate that referenced this pull request Dec 6, 2021
Revert "Add handler E2E tests for DNS configuration (nmstate#866)"
5368db6 
This reverts commit 17c0b02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon qinqon approved these changes

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yboaron @qinqon @kubevirt-bot