Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.47] Fix applying vlan filtering via nmcli #903

Conversation

rhrazdil
Copy link
Collaborator

Backport of #901
Only apply vlan filtering via nmcli to bridges and ports
that are listed in desiredState and also exist in current
state.

Signed-off-by: Radim Hrazdil rhrazdil@redhat.com

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE

Only apply vlan filtering via nmcli to bridges and ports
that are listed in desiredState and also exist in current
state.

Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
@kubevirt-bot kubevirt-bot added kind/bug release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 26, 2021
@rhrazdil
Copy link
Collaborator Author

/cc @qinqon

@qinqon
Copy link
Member

qinqon commented Nov 26, 2021

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2021
@qinqon
Copy link
Member

qinqon commented Nov 26, 2021

/retest

@rhrazdil
Copy link
Collaborator Author

/test pull-kubernetes-nmstate-e2e-operator-k8s-0.47

1 similar comment
@rhrazdil
Copy link
Collaborator Author

/test pull-kubernetes-nmstate-e2e-operator-k8s-0.47

@kubevirt-bot kubevirt-bot merged commit c2b607d into nmstate:release-0.47 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants