capture: Calculated captured state from nmstatectl

[qinqon]

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What this PR does / why we need it:
Calculating the captured state with the NNS is problematic since there
are some latencies between nmstatectl set and NNS being updated, so it
could happend that next NNCP is calculated with inaccurate network
configuration. This change read the currentState from nmstatectl to get
accurate data.

Special notes for your reviewer:
Fix bz https://bugzilla.redhat.com/show_bug.cgi?id=2057613

Release note:

Calculate captured state from nmstatectl show outpout

[rhrazdil]

The fix looks good.
@qinqon Interesting that we didn't hit this issue in u/s CI, do you think it's worth adding a test scenario that reproduced this in a followup?

/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhrazdil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qinqon]

/cherry-pick release-0.64

[kubevirt-bot]

@qinqon: once the present PR merges, I will cherry-pick it on top of release-0.64 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhrazdil]

/lgtm

[qinqon]

/retest

[qinqon]

The fix looks good. @qinqon Interesting that we didn't hit this issue in u/s CI, do you think it's worth adding a test scenario that reproduced this in a followup?

Since it's a race it depends how much time happends between one NNCP and the next, also what do we do on the next NNCP, if both NNCP use capture and one capture is using the previous as input then we can end with the issue at hand.

[qinqon]

/retest

[rhrazdil]

Since it's a race it depends how much time happends between one NNCP and the next, also what do we do on the next NNCP, if both NNCP use capture and one capture is using the previous as input then we can end with the issue at hand.

Thanks, understood.

[qinqon]

/cherry-pick release-0.64

[kubevirt-bot]

@qinqon: once the present PR merges, I will cherry-pick it on top of release-0.64 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[qinqon]

/retest

It suffers from DNS resolve ping, let's retry

: failed checking DNS connectivity: [failed looking up NS root-server.net using name sever 192.168.66.2: lookup root-server.net on [fd00::1]:53: server misbehaving failed looking up NS root-server.net using name sever fd00::1: lookup root-server.net on [fd00::1]:53: dial udp [fd00::1]:53: connect: network is unreachable]: failed running probes after rollback: failed runnig probe 'dns' with after network reconfiguration -> currentState: ---

[qinqon]

/retest

[rhrazdil]

This time, the go build failed again
/test pull-kubernetes-nmstate-e2e-handler-k8s

[qinqon]

This time, the go build failed again /test pull-kubernetes-nmstate-e2e-handler-k8s

ARM build sometimes fail...

[kubevirt-bot]

@qinqon: #998 failed to apply on top of branch "release-0.64":

Applying: capture: Calculated captured state from nmstatectl
Using index info to reconstruct a base tree...
M	controllers/handler/nodenetworkconfigurationpolicy_controller.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/handler/nodenetworkconfigurationpolicy_controller.go
CONFLICT (content): Merge conflict in controllers/handler/nodenetworkconfigurationpolicy_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 capture: Calculated captured state from nmstatectl
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.