Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace serde_yaml #2629

Open
cathay4t opened this issue Mar 26, 2024 · 5 comments
Open

Replace serde_yaml #2629

cathay4t opened this issue Mar 26, 2024 · 5 comments

Comments

@cathay4t
Copy link
Member

The maintainer of serde_yaml has announced the demise of that crate:
https://github.com/dtolnay/serde-yaml

We need to replace it.

@cathay4t
Copy link
Member Author

Considering we never hit any problem of using serde_yaml, let's keep using it till better option shows up.

@jubril-adeyi
Copy link

Hello @cathay4t do you mind sharing what replacement options are available for serde-yaml ?
i'd like to work on this issue

@Mabwas
Copy link

Mabwas commented Apr 1, 2024

@cathay4t can i work this please

@cathay4t
Copy link
Member Author

cathay4t commented Jul 8, 2024

Hi @jubril-adeyi @Mabwas, I don't have preference on replacement yet.
Replacing a dependency need to answer these questions with proofs:

  1. Is the new crate API stable enough?
  2. Is the new crate well tested by community?
  3. YAML API is the key API of nmstate, no CI test failure should caused by this change.

Personally, unless deprecated serde-yaml proved to be holding unfixed bugs, I would like to keep using it.

So, it might not be a good task for new contributor.

If you like to accept the challenge, PR is always welcome once you have proofs on above questions.

@ihuguet
Copy link
Member

ihuguet commented Aug 1, 2024

I also think that keeping serde_yaml is the best choice, for the moment. However, this seems a potential good replacement (which is a continuation of serde_yaml): https://crates.io/crates/serde_yaml_ng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants