nm: Fix converting memory-only profile to persistent #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
- Coverage 57.65% 57.61% -0.04%
==========================================
Files 56 56
Lines 5174 5179 +5
==========================================
+ Hits 2983 2984 +1
- Misses 2191 2195 +4
Continue to review full report at Codecov.
|
When converting memory-only profile to persistent using simple desire state with `state: up` only, the memory only profile will not be converted to persistent. This is caused by `nm/applier.py` skip profile creation if desire state is only `state: up`. The fix is checking whether current profile's persistent state is equal to desired. Integration test case added. Signed-off-by: Gris Ge <fge@redhat.com>
cathay4t
force-pushed
the
fix_bz_1859844
branch
from
45b96b1
to
e384362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting memory-only profile to persistent using simple desire
state with
state: uponly, the memory only profile will not beconverted to persistent.
This is caused by
nm/applier.pyskip profile creation if desire stateis only
state: up.The fix is checking whether current profile's persistent state is equal
to desired.
Integration test case added.