Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nm/bond: Keep child interface when bond mode change #1341

Merged
merged 1 commit into from Sep 28, 2020
Merged

nm/bond: Keep child interface when bond mode change #1341

merged 1 commit into from Sep 28, 2020

Conversation

cathay4t
Copy link
Member

Due to NetworkManager bug https://bugzilla.redhat.com/1881318 , the
bond child will be deactivated when bond mode changed.

Workaround is manually activate bond child.

Integration test case included and marked as tier1 as oVirt is depending
on it.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/nmstate-nmstate-1341
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@codecov
Copy link

codecov bot commented Sep 22, 2020 •
edited

Codecov Report

Merging #1341 into base will decrease coverage by 0.06%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             base    #1341      +/-   ##
==========================================
- Coverage   58.45%   58.38%   -0.07%     
==========================================
  Files          68       68              
  Lines        5368     5376       +8     
==========================================
+ Hits         3138     3139       +1     
- Misses       2230     2237       +7
Impacted Files Coverage Δ
libnmstate/nm/profile.py 25.06% <12.50%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46b7df...c5466bf. Read the comment docs.

ffmancera
ffmancera approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@ffmancera ffmancera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ffmancera ffmancera added Waiting_Rebase Current PR is approved, but waiting rebase. and removed Wait_Review labels Sep 23, 2020
@EdDev
Copy link
Member

EdDev commented Sep 24, 2020

Are you planning to remove this workaround after it is fixed by NM? If so, how do you track it?

@ffmancera
Copy link
Member

Are you planning to remove this workaround after it is fixed by NM? If so, how do you track it?

I think we could create an issue and track it there.

tyll
tyll reviewed Sep 25, 2020
View reviewed changes
libnmstate/nm/profile.py
@@ -123,6 +123,7 @@ def _group_profile_by_action_order(self):
def _prepare_state_for_profiles(self, net_state):
_preapply_dns_fix_for_profiles(self._ctx, net_state)
_mark_nm_external_subordinate_changed(self._ctx, net_state)
_mark_mode_changed_bond_child_interface_as_changed(net_state)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with codecov? It is strange that this line is not covered since there is a specific test that should use this code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, it is on our TO-DO list to investigate what is going on with codecov. It is not working properly. I am going to create an issue

@cathay4t cathay4t mentioned this pull request Sep 28, 2020
Open
@cathay4t
Copy link
Member Author

cathay4t commented Sep 28, 2020 •
edited

Are you planning to remove this workaround after it is fixed by NM? If so, how do you track it?

I don't think we have plan to bump our minimum support NM version recently. So I assume we will need the workaround for a
long time. But I will use #1350 tracking this.

@ffmancera ffmancera mentioned this pull request Sep 28, 2020
Open
@cathay4t
nm/bond: Keep child interface when bond mode change
c5466bf 
Due to NetworkManager bug https://bugzilla.redhat.com/1881318 , the
bond child will be deactivated when bond mode changed.

Workaround is manually activate bond child.

Integration test case included and marked as tier1 as oVirt is depending
on it.

Signed-off-by: Gris Ge <fge@redhat.com>
@cathay4t cathay4t merged commit 4a7c174 into nmstate:base Sep 28, 2020
@cathay4t cathay4t deleted the bond_mode_change branch September 28, 2020 14:00
@cathay4t cathay4t restored the bond_mode_change branch September 28, 2020 14:00
@cathay4t cathay4t deleted the bond_mode_change branch September 28, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyll tyll tyll left review comments

@ffmancera ffmancera ffmancera approved these changes

@EdDev EdDev Awaiting requested review from EdDev

Assignees
No one assigned
Labels
Waiting_Rebase Current PR is approved, but waiting rebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cathay4t @EdDev @ffmancera @tyll