nm: Add support of multiconnect profile #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## base #1499 +/- ##
==========================================
- Coverage 57.87% 57.83% -0.05%
==========================================
Files 83 83
Lines 6388 6396 +8
==========================================
+ Hits 3697 3699 +2
- Misses 2691 2697 +6
Continue to review full report at Codecov.
|
cathay4t
force-pushed
the
fix_nm_multiconnect
branch
from
4a5835b
to
8f87024
Compare
cathay4t
force-pushed
the
fix_nm_multiconnect
branch
from
8f87024
to
d005e61
Compare
When certain profile holding `connection.multi-connect multiple`, it means this profile will be apply to all interfaces matching. In this case, nmstate should not modify this multiconnect profile but creating new one. Integration test case included. Signed-off-by: Gris Ge <fge@redhat.com>
cathay4t
force-pushed
the
fix_nm_multiconnect
branch
from
d005e61
to
a31f767
Compare
cathay4t
added
Waiting_Rebase
|
Investigating the constant failure of CI with nm master. |
|
The CI failure is caused by NM bug which is not releated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When certain profile holding
connection.multi-connect multiple, itmeans this profile will be apply to all interfaces matching. In this
case, nmstate should not modify this multiconnect profile but creating
new one.
Integration test case included.