dns: Allow user to change dns search or search only #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## base #1777 +/- ##
==========================================
+ Coverage 93.80% 93.83% +0.02%
==========================================
Files 84 84
Lines 7087 7103 +16
==========================================
+ Hits 6648 6665 +17
+ Misses 439 438 -1
Continue to review full report at Codecov.
|
cathay4t
force-pushed
the
py_dns_search
branch
3 times, most recently
from
b890685
to
e9ee251
Compare
|
@cathay4t: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
cathay4t
force-pushed
the
py_dns_search
branch
from
e9ee251
to
7a5e687
Compare
When user only desired DNS search or server, remaining configure should be copy from current status. Unit test case and integration test cases included. Signed-off-by: Gris Ge <fge@redhat.com>
cathay4t
force-pushed
the
py_dns_search
branch
from
7a5e687
to
3ff9c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user only desired DNS search or server, remaining configure should
be copy from current status.
Unit test case and integration test cases included.