DHCPv4: Add support of client ID #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathay4t
force-pushed
the
dhcpv4_id
branch
3 times, most recently
from
84e269b
to
99aae33
Compare
|
@cathay4t: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ffmancera
approved these changes
Jun 1, 2022
Per RFC 2132 and 4361, we add `Dhcpv4ClientId` to `InterfaceIpv4`: * `Dhcpv4ClientId::LinkLayerAddress`, shown as `ll`. * `Dhcpv4ClientId::IaidPlusDuid`, show as `iaid+duid`. * `Dhcpv4ClientId::Other(String)` for hex string or backend specific client id type. For NetworkManager, `ll` is converted to `mac`, the `iaid+duis` is converted to `duid`. Integration test case included. Signed-off-by: Gris Ge <fge@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 2132 and 4361, we add
Dhcpv4ClientIdtoInterfaceIpv4:Dhcpv4ClientId::LinkLayerAddress, shown asll.Dhcpv4ClientId::IaidPlusDuid, show asiaid+duid.Dhcpv4ClientId::Other(String)for hex string or backend specificclient id type.
For NetworkManager,
llis converted tomac, theiaid+duisis converted toduid.Integration test case included.