Don't copy existing config when disabling IPv4/v6 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Big thanks to @phoracek for finding the bug. |
cathay4t
changed the title
Only preserving existing IP configurations when IPv4/v6 is enabled. Signed-off-by: Gris Ge <fge@redhat.com>
cathay4t
changed the title
cathay4t
force-pushed
the
clear_when_down
branch
from
e361f76
to
2086f6f
Compare
|
The commit message should probably be something like this to follow our style guide: IMHO the summary and the next line essentially say the same, so one of them is enough. |
EdDev
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only preserving existing IP configurations when IPv4/6 is enabled.
Fixes: #188