NM/device: Handle activation failures for connections #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdDev
reviewed
Dec 19, 2018
EdDev
reviewed
Dec 19, 2018
tyll
force-pushed
the
activate_connection
branch
2 times, most recently
from
c15f61b
to
ff2c35f
Compare
EdDev
requested changes
Dec 19, 2018
tyll
force-pushed
the
activate_connection
branch
3 times, most recently
from
08cc600
to
502e0b9
Compare
When a connection is activated, the user data for the active connection callback does not contain a device object. Therefore report the connection ID instead of the device instead. Signed-off-by: Till Maas <opensource@till.name>
tyll
force-pushed
the
activate_connection
branch
from
502e0b9
to
345c222
Compare
|
ci test please |
EdDev
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connection is activated, the user data for the active connection
callback does not contain a device object. Therefore report the
connection ID instead of the device instead.
Signed-off-by: Till Maas opensource@till.name
fixes #198