Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: Support IPv6 link local address as DNS nameserver #2105

Merged
merged 1 commit into from Nov 17, 2022

Conversation

cathay4t
Copy link
Member

When using IPv6 link local address as DNS nameserver, interface name is
required, for example: fe80::deef:1%eth1

Example yaml:

---
dns-resolver:
  config:
    search:
    - example.com
    - example.org
    server:
    - fe80::deef:1%eth1
    - 2001:4860:4860::8844
    - 8.8.4.4
    - 8.8.8.8

Restrictions:

  • You cannot have 2+ interface names in DNS server names. Massive work
    required to handle the DNS ordering between interfaces with the
    design of NetworkManager.

  • All other normal IPv6 nameserver will also stored in link local
    interface if exists.

Unit test cases and integration test case included.

@kubevirt-bot
Copy link
Collaborator

@cathay4t: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-nmstate-integ_tier1-k8s 3148c29 link false /test pull-nmstate-integ_tier1-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

When using IPv6 link local address as DNS nameserver, interface name is
required, for example: `fe80::deef:1%eth1`

Example yaml:

```yml
---
dns-resolver:
  config:
    search:
    - example.com
    - example.org
    server:
    - fe80::deef:1%eth1
    - 2001:4860:4860::8844
    - 8.8.4.4
    - 8.8.8.8
```

Restrictions:
 * You cannot have 2+ interface names in DNS server names. Massive work
   required to handle the DNS ordering between interfaces with the
   design of NetworkManager.

 * All other normal IPv6 nameserver will also stored in link local
   interface if exists.

Unit test cases and integration test case included.

Signed-off-by: Gris Ge <fge@redhat.com>
@ffmancera ffmancera merged commit e1cae11 into nmstate:base Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants