Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipsec: Support type, hostaddrfamily and clientaddrfamily options #2526

Merged
merged 3 commits into from Jan 17, 2024

Conversation

cathay4t
Copy link
Member

Added support of:

  • type: tunnel|transport
  • clientaddrfamily: ipv4|ipv6
  • hostaddrfamily: ipv4|ipv6

Integration test cases included.

@cathay4t
Copy link
Member Author

The NetworkManager-libreswan code is not ready yet for ipv6 yet. Please wait test feedback.

The test on type: transport passed.

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/nmstate-nmstate-2526
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@cathay4t cathay4t force-pushed the ipsec_type branch 6 times, most recently from d8de547 to b92cd34 Compare January 17, 2024 08:17
We do not have test run for CentOS stream 8.

Signed-off-by: Gris Ge <fge@redhat.com>
With NetworkManager-libreswan-1.2.18-1.el9.x86_64 in CentOS Stream 9, we
can remove xfail of these tests:

 * `test_ipsec_ipv4_libreswan_psk_auth_with_ipsec_iface`
 * `test_ipsec_ipv4_libreswan_psk_auth_with_dpd`
 * `test_ipsec_ipv4_libreswan_authby`

Signed-off-by: Gris Ge <fge@redhat.com>
Added support of:
 * `type: tunnel|transport`
 * `clientaddrfamily: ipv4|ipv6`
 * `hostaddrfamily: ipv4|ipv6`

Integration test cases included.

Signed-off-by: Gris Ge <fge@redhat.com>
Copy link
Member

@ffmancera ffmancera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cathay4t cathay4t removed the Work_Ongoing Not ready to be merged label Jan 17, 2024
@cathay4t cathay4t merged commit d7d62db into nmstate:base Jan 17, 2024
36 checks passed
@cathay4t cathay4t deleted the ipsec_type branch January 17, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants