ipsec: Treat DHCPv4 off with no static address as IPv4 disabled #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
ffmancera
approved these changes
Feb 21, 2024
When user desired `dhcp: off` with no static address for IPSec interface, nmstate will fail as verification error. For IPSec connection, the DHCPv4 off with empty IP address should be treated by IP disabled as we have no intention on supporting routes on IPSec connection yet. The route should be set by IPSec daemon or to xfrm interface. Unit test case and integration test cases included. Signed-off-by: Gris Ge <fge@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user desired
dhcp: offwith no static address for IPSec interface,nmstate will fail as verification error.
For IPSec connection, the DHCPv4 off with empty IP address should be
treated by IP disabled as we have no intention on supporting routes on
IPSec connection yet. The route should be set by IPSec daemon or to xfrm
interface.
Unit test case and integration test cases included.