test: Add IPv6 ipsec tests #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathay4t
force-pushed
the
ipsec_ipv6
branch
2 times, most recently
from
322a156
to
9caf3a0
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
cathay4t
force-pushed
the
ipsec_ipv6
branch
4 times, most recently
from
36cea05
to
ee6dff5
Compare
ihuguet
suggested changes
May 29, 2024
tests/integration/ipsec_test.py
Outdated
| right: {IpsecTestEnv.HOSTB_IPV6_CS} | ||
| rightid: '@hostb.example.org' | ||
| ipsec-interface: 97 |
There was a problem hiding this comment.
Why this change?
BTW, adding ipsec-interface uses a different mode in libreswan (Routing based VPN instead of Policy based VPN). Things that works well with one of them might fail with the other (probably because of bugs in NM-libreswan). Should we do all the tests in both modes maybe?
There was a problem hiding this comment.
We can only tell whether autoconf IPv6 is disabled as desired with dedicate ipsec xfrm interface.
ihuguet
approved these changes
May 30, 2024
cathay4t
force-pushed
the
ipsec_ipv6
branch
2 times, most recently
from
3d8fce7
to
0143a21
Compare
liangwen12year
approved these changes
Jun 11, 2024
|
Please resolve the conflict, thanks. |
Instead of checking micro version, we should convert version to a
integer to compare using this formula:
10000 * major_version + 100 * minor_version + micro_version
Introduced `nm_libreswan_version_int()` and `version_str_to_int()` for
this and fixed all version check in ipsec test.
Signed-off-by: Gris Ge <fge@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With NetworkManager-libreswan 1.2.22+, IPv6 libreswan ipsec tunnel is
supported.
Integration test cases included.
Resolves: https://issues.redhat.com/browse/RHEL-32279