Validate interface in desired port list of controller

[liangwen12year]

When the last port of the controller is absent, the port list of the controller becomes empty, in the situaiton of applying the controller and port settings again, before generating the port config, we should not validate if interface is in the port list of controller when port is empty.

Resolves: https://issues.redhat.com/browse/RHEL-31977

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/nmstate-nmstate-2693
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[cathay4t]

Instead of checking whether it is empty, you should check whether the port list is desired or not.

With your current path, you incorrectly allows this YAML:

---
interfaces:
- name: br0
  type: linux-bridge
  bridge:
    ports: []
- name: bond99
  type: bond
  state: up
  controller: br0
  link-aggregation:
    mode: balance-rr
    port:
    - eth2
    - eth1

[liangwen12year]

Instead of checking whether it is empty, you should check whether the port list is desired or not.

With your current path, you incorrectly allows this YAML:

---
interfaces:
- name: br0
  type: linux-bridge
  bridge:
    ports: []
- name: bond99
  type: bond
  state: up
  controller: br0
  link-aggregation:
    mode: balance-rr
    port:
    - eth2
    - eth1

Thanks for the comment, I updated the patch.

[cathay4t]

Please include unit test case for

---
interfaces:
- name: br0
  type: linux-bridge
  bridge:
    ports: []
- name: bond99
  type: bond
  state: up
  controller: br0
  link-aggregation:
    mode: balance-rr
    port:
    - eth2
    - eth1

[cathay4t]

Your integration test case test_port_remove_and_validate_port_controller has no clean up. Please introduce a fixture and do the clean up no matter test case passed or not.

[liangwen12year]

Please include unit test case for

---
interfaces:
- name: br0
  type: linux-bridge
  bridge:
    ports: []
- name: bond99
  type: bond
  state: up
  controller: br0
  link-aggregation:
    mode: balance-rr
    port:
    - eth2
    - eth1

I added the unit test.

[liangwen12year]

Your integration test case test_port_remove_and_validate_port_controller has no clean up. Please introduce a fixture and do the clean up no matter test case passed or not.

I updated the code to reuse the existing fixture for proper cleanup, thanks.