Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Switch codecov with coveralls #683

Merged
merged 1 commit into from Jan 9, 2020

Conversation

tyll
Copy link
Member

@tyll tyll commented Jan 9, 2020

Codecov does not seem to properly support multiple jobs but coveralls
does. Therefore use codecov for the CentOS 8 integration tests and
coveralls for everything else.

Signed-off-by: Till Maas opensource@till.name

Codecov does not seem to properly support multiple jobs but coveralls
does. Therefore use codecov for the CentOS 8 integration tests and
coveralls for everything else.

Signed-off-by: Till Maas <opensource@till.name>
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #683 into master will increase coverage by 22.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #683       +/-   ##
===========================================
+ Coverage   66.25%   88.79%   +22.54%     
===========================================
  Files          27       27               
  Lines        2160     2160               
===========================================
+ Hits         1431     1918      +487     
+ Misses        729      242      -487
Impacted Files Coverage Δ
libnmstate/validator.py 72.14% <0%> (-22.86%) ⬇️
libnmstate/nm/bond.py 89.28% <0%> (-3.58%) ⬇️
libnmstate/nm/ovs.py 81.45% <0%> (+0.8%) ⬆️
libnmstate/netinfo.py 96.72% <0%> (+1.63%) ⬆️
libnmstate/metadata.py 93.56% <0%> (+6.93%) ⬆️
libnmstate/nm/team.py 100% <0%> (+12.5%) ⬆️
libnmstate/netapplier.py 88.09% <0%> (+23.8%) ⬆️
nmstatectl/nmstatectl.py 79.89% <0%> (+25.77%) ⬆️
libnmstate/nm/ipv4.py 100% <0%> (+26.26%) ⬆️
libnmstate/nm/applier.py 97.44% <0%> (+26.8%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228d72b...e27bb17. Read the comment docs.

Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@EdDev EdDev merged commit 037f00e into nmstate:master Jan 9, 2020
@tyll tyll deleted the codecov_coveralls branch January 9, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants