team: Fix failure of creating team interface with slaves #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmancera
reviewed
Feb 17, 2020
ffmancera
reviewed
Feb 17, 2020
Got failure when creating team interface with slaves caused by:
* When create setting, the `create_setting()` of `nm/team.py`
altered the data layout which trigger failure in
`merge_interfaces` at the verification stage.
* The slave interface does not set `connection.master` and
`connection.slave-type`.
Fixed and also added integration test to assert on the run time status
of team interface.
Signed-off-by: Gris Ge <fge@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got failure when creating team interface with slaves caused by:
create_setting()ofnm/team.pyaltered the data layout which trigger failure inmerge_interfacesat the verification stage.connection.masterandconnection.slave-type.Fixed and also added integration test to assert on the run time status
of team interface.