Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionProfile: Use interface name from NM.RemoteConnection #874

Merged
merged 1 commit into from Mar 2, 2020
Merged

ConnectionProfile: Use interface name from NM.RemoteConnection #874

merged 1 commit into from Mar 2, 2020

Conversation

tyll
Copy link
Member

@tyll tyll commented Feb 27, 2020

ActiveConnection.devname might be None if the activation failed for
virtual interfaces. Therefore use the interface name from the
NM.RemoteConnection for logging.

Signed-off-by: Till Maas opensource@till.name

@tyll tyll mentioned this pull request Feb 27, 2020
Merged
@coveralls
Copy link

coveralls commented Feb 27, 2020 •
edited

Coverage Status

Coverage remained the same at ?% when pulling 0bd2012 on tyll:devname2 into 49d8a2e on nmstate:master.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/nmstate-nmstate-874
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

cathay4t
cathay4t approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@cathay4t cathay4t added the Waiting_Rebase Current PR is approved, but waiting rebase. label Feb 28, 2020
@tyll
ConnectionProfile: Use interface name from NM.RemoteConnection
0bd2012 
ActiveConnection.devname might be None if the activation failed for
virtual interfaces. Therefore use the interface name from the
NM.RemoteConnection for logging.

Signed-off-by: Till Maas <opensource@till.name>
@tyll tyll added backport candidate and removed Waiting_Rebase Current PR is approved, but waiting rebase. labels Feb 28, 2020
ffmancera
ffmancera approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@ffmancera ffmancera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@cathay4t cathay4t merged commit c36c367 into nmstate:master Mar 2, 2020
@ffmancera ffmancera mentioned this pull request Mar 2, 2020
Merged
@tyll tyll deleted the devname2 branch March 2, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathay4t cathay4t cathay4t approved these changes

@ffmancera ffmancera ffmancera approved these changes

@EdDev EdDev Awaiting requested review from EdDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tyll @coveralls @cathay4t @ffmancera