nm applier: only create ethernet when explicitly #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This was
linked to
issues
Mar 9, 2020
EdDev
reviewed
Mar 9, 2020
cathay4t
force-pushed
the
eth_section
branch
2 times, most recently
from
6142ff4
to
1ebeef4
Compare
Creating ethernet configuration when user not requested will
cause two major problems:
* Adding slave to newly create bridge will cause bridge link down.
* Cannot switch bond mode from 1(active-backup) to 5(balance-tlb).
To fix the problem, only create ethernet/wired setting when user
explicitly requested.
Remove the xfail of test case for changing bond mode from 1(active-backup)
to 5(balance-tlb).
Remove the workaround in test case for adding slave to newly created
bridge without link state down.
Add test case showing old ethernet configuration will not be removed when
desire state does not include so.
Signed-off-by: Gris Ge <fge@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating ethernet configuration when user not requested will
cause two major problems:
To fix the problem, only create ethernet/wired setting when user
explicitly requested.
Remove the xfail of test case for changing bond mode from 1(active-backup)
to 5(balance-tlb).
Remove the workaround in test case for adding slave to newly created
bridge without link state down.